fix: ga 'api request rest' command @W-23493730@ - #194
Merged
Conversation
k80bowman
requested changes
Aug 10, 2026
k80bowman
left a comment
k80bowman
left a comment
There was a problem hiding this comment.
This all looks fine, just one recommendation.
Comment on lines
+26
to
+45
| export function redactError(error: unknown): unknown { | ||
| if (error instanceof Error && 'options' in error) { | ||
| const opts = error as Error & { options?: { headers?: Record<string, unknown> } }; | ||
| if (opts.options?.headers) { | ||
| for (const key of Object.keys(opts.options.headers)) { | ||
| if (key.toLowerCase() === 'authorization') { | ||
| opts.options.headers[key] = '[REDACTED]'; | ||
| } | ||
| } | ||
| } | ||
| } | ||
| return error; | ||
| } | ||
|
|
||
| export type ApiResponseResult = { | ||
| statusCode: number; | ||
| headers: Record<string, string | string[]>; | ||
| body: AnyJson | string; | ||
| }; | ||
|
|
There was a problem hiding this comment.
I feel like it would be better to move this to SfError instead of having it live only in this plugin. That way we can easily redact authorization headers from all error messages, instead of only error messages from this plugin.
There was a problem hiding this comment.
per discussion, we are good to keep this here for now.
k80bowman
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
GA's
api request restcommandWhat issues does this PR fix or reference?
@W-23493730@